Sam James

Results 860 comments of Sam James

> Do I understand the concern with the current -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 pattern correctly ... Exactly. It's problematic also if wanting to do testing with =2 or =1 for coverage but...

> Upstream never intended for the Python dependency to be optional, just the bindings: [SSSD/sssd#7443](https://github.com/SSSD/sssd/pull/7443) . However, the build system cannot handle it. Since we're dependant on Python anyway, might...

I generally don't pay attention to things w/ failing CI unless someone asks for help. Are you stuck on it, or?

Please git mv the old ebuilds to change it to (+) with no keyword changes, just note in the commit message that newer sssd always has it on.

Squash them as well (the sudo ones) or I can in 5m, thanks

Mind doing a quick PR to add that UID/GID to api.git too please? (github.com/gentoo/api-gentoo-org)

I'd missed that you'd prepared this. There's a fair bit in master which needs a release and we should do one for https://bugs.gentoo.org/890577 especially, so I don't want to rush...

Could you add `Signed-off-by` please? Thanks.

How's it looking now? OK to proceed to content review? And do we want to commit this as-is, or review the content here? Either is fine with me. I guess...