Sam James
Sam James
Let me know how this goes... ```Dockerfile FROM gentoo/stage3 # Disable bits which don't work within Docker. RUN echo 'FEATURES="-ipc-sandbox -pid-sandbox -network-sandbox -usersandbox -mount-sandbox -sandbox"' | cat >> /etc/portage/make.conf #...
My guess is you OOMed (check dmesg?) -- could you try changing the MAKEOPTS line to -j4 or something? (You want it to be roughly: min(threads_on_your_cpu, RAM/2GB).)
I think it's worth passing some arguments to be safe. Even better would be to never call `cargo` directly and always through a variable to make sure we don't drop...
I haven't reviewed the implementation properly, but one initial hesitation I had was doing this everywhere. That got fixed by the opt-in that got suggested later on and works for...
> Upstream merged my PR. We can do a version bump now instead of merging this. Go for it? :)
Please handle feedback in existing PRs before filing new ones - thanks! Otherwise the same issues might be repeated and then it's harder for me to review and you to...
Please update the PR body text. Also, the closes URLs are invalid (missing a /). cc @eli-schwartz
I'll seek review when TODO is addressed, but feel free to comment on the stuff not covered by that.
Merged in e802488062f680f9a5ffe2a2ccb3bbefc3a8adb5 with some minor TODO left which I'll return to.
Please include rationale in the commit messages (at the least the stuff you said in the PR body, maybe more). It also needs a `Closes:` tag for the bug. I...