genshin.py icon indicating copy to clipboard operation
genshin.py copied to clipboard

Fix abyss battle timestamp

Open BachelorForever opened this issue 2 years ago • 1 comments

Fix abyss battle timestamp, it should be datetime not date

BachelorForever avatar Jun 24 '22 01:06 BachelorForever

What difference does this actually make? I feel like the exact time wasn't even given.

Might be a good idea to find out what timezone it uses since most of the time it's unfortunately not UTC.

thesadru avatar Jun 24 '22 05:06 thesadru

Hi @thesadru, it would be great if we could merge it.

We are working on a telegram bot with a feature that shows the abyss data. For this particular feature, we think it would be best to display both date and time, as it looks like what hoyolab does. We understand that this timestamp is UTC, and it needs to be converted to the user's time zone.

Much appreciate.

image

chuangbo avatar Oct 08 '22 10:10 chuangbo

ah cool well that solves it

thesadru avatar Oct 08 '22 10:10 thesadru