genshin.py icon indicating copy to clipboard operation
genshin.py copied to clipboard

get_banner_details still returns 4.0 first phase banners

Open emredesu opened this issue 1 year ago • 4 comments

Hey! It seems like the API is no longer returning the up-to-date banners, it seems to be stuck on Lyney-Yelan banners. Here's how the output looks:

async def getbanners():
    banners = await client.get_banner_details(game = genshin.types.Game.GENSHIN)
    for banner in banners:
    print(banner.name)

>>> asyncio.run(getbanners())
Standard Wish "Wanderlust Invocation"
Event Wish "Conjuring Chiaroscuro"
Event Wish "Discerner of Enigmas"
Event Wish "Epitome Invocation"

"Conjuring Chiaroscuro" is the Lyney banner, which should have been gone a few days ago.

emredesu avatar Sep 07 '23 17:09 emredesu

Yeah looks like hoyo stopped updating that endpoint, gotta hope it comes to enka.

thesadru avatar Sep 14 '23 12:09 thesadru

I've started extracting the banner data links from the in-game client and reading them from a gist myself. I will be updating this with every banner, you could use my gist in the meanwhile if you'd like.

emredesu avatar Sep 14 '23 14:09 emredesu

The endpoint moved, I think.

EffortlessFury avatar Jan 18 '24 18:01 EffortlessFury

Yep I've been using that endpoint over manually updating my gist too, works wonderfully.

emredesu avatar Jan 18 '24 19:01 emredesu