builds the node_id and relationship_id on cypher query results

[alank64]

On performing a cypher query, the results should contain the node_id or relationship_id in the results as the other non-cypher methods do. Without this there is no way to obtain the id in the results to perform further operations.

This pull req takes from the self parameter returned in the REST response and inserts the {node|relationship}_id into each of the results.

[therubymug]

Hello Andrew! Thanks for the pull request! I have a few comments:

• The Travis CI build failed
• The git commit history on this branch is messy (this makes it harder to merge).
• Keep your commits atomic, you may have to squash them into one before submitting the pull request. More on that
• Please follow these conventions when writing git commit messages.
• re: neo4j_id in the results, this is something I already have in the works in the virtus branch. Same basic idea, if the cypher response has a "self" key, it scrapes the id from it. Note: there are cases where one would explicitly return one or more columns that exclude the neo4j_id. e.g. START n=node:terminators(node_type='Terminator') RETURN n.name AS name

[linko]

Hey @therubymug @alank64

Can I help you with this PR? What there needs to do to merge it? It seems that this and next PRs have usefull staff and docs

[alank64]

Yes, very sorry, I made an attempt but got lost in the details of Travis and the likes. Now I'm overloaded with two tight deadlines on two simultaneous projects and won't have the time for a while.

You are welcome to go to my branch and clean/create and make the pull requests. Is that what you are asking? Or it might be easier to branch from Keymaker and cut/copy my pull requests into your branch, I think my branch is kinda messed up! Let me know, I'll add you as contributor to alank64/keymaker if you want.

On Tue, Apr 23, 2013 at 11:17 AM, Ivan Linko [email protected]:

Hey @therubymug https://github.com/therubymug @alank64https://github.com/alank64

Can I help you with this PR? What there needs to do to merge it? It seems that this and next PRs have usefull staff and docs

— Reply to this email directly or view it on GitHubhttps://github.com/therubymug/keymaker/pull/8#issuecomment-16864696 .