keymaker
keymaker copied to clipboard
therubymug
Rebuilded pull request from alank64
- Rebuilded commits from PR #7 ,#8
- Added psych dependency ~> 1.3 to run on ruby 1.9.2 (Error: can't dump anonymous class Class)
@linko sorry. I've been really busy the last few weeks! I looks like I may have some time towards the end of this week. :-)
@linko sorry, your pull request only covers part of what my vision for what this feature is/should be. This is why I haven't merged this into master. Part of my virtus branch is aiming to do what you're doing in this pull request. I just have not had time (been busy with paid work) to finish that branch! Again, sorry about the delay it's just the way it goes sometimes. :-/
Rogelio,
Maybe others could contribute to your Virtus branch, like if you were to outline the direction you want it to go, or the idea your aiming for.
This way we wouldn't waste effort on implementing things that your branch changes and it would free you a little.
Keymaker is your baby, but just giving suggestions that might make it move forward faster. ;)
On Wed, Jun 26, 2013 at 6:06 PM, Rogelio J. Samour <[email protected]
wrote:
@linko https://github.com/linko sorry, your pull request only covers part of what my vision for what this feature is/should be. This is why I haven't merged this into master. Part of my virtus branch is aiming to do what you're doing in this pull request. I just have not had time (been busy with paid work) to finish that branch! Again, sorry about the delay it's just the way it goes sometimes. :-/
— Reply to this email directly or view it on GitHubhttps://github.com/therubymug/keymaker/pull/10#issuecomment-20083778 .
Hey!
I'm using it in production already for about 5 months :) Maybe it's time to merge it? Only if it's a part of next big changes/updates.