Pieter Roggemans

Results 223 comments of Pieter Roggemans

This is what I use in geofileops: - https://github.com/geofileops/geofileops/blob/master/geofileops/util/geofiletype.py - \+ https://github.com/geofileops/geofileops/blob/master/geofileops/util/geofiletypes.csv - Too few tests can be found here: https://github.com/geofileops/geofileops/blob/master/tests/test_geofiletype.py It's a combination of a dataclass that's filled up...

For creating datasets there are 3 types of options relevant that need to be seperate: - dataset creation options: to be passed to GDALCreate() - layer creation options: to be...

> It seems that Fiona passes the `kwargs` to both the dataset and layer creation. And I suppose that GDAL will then ignore the ones that are not relevant? GDAL...

> If you look at eg https://gdal.org/drivers/vector/gpkg.html or https://gdal.org/drivers/vector/shapefile.html, I think in general the most relevant options are "layer creation options". So personally I would keep the convenience of automatically...

At least GDAL makes an effort to deal properly with nan vs NULL. Because different filetypes treat them differently, the GDAL drivers do so as well. Some examples: - in...

> It would indeed be either all NaN or all Null, not a mix of them (which makes sense, because also pandas and numpy cannot represent a mix and so...

> Hey @theroggy have you done any work on this? If not I might have a look if that's okay. @m-richards No I haven't... feel free!

Hmm... indeed... when writing it seems the datetimes at the moment will be implicitly converted to UTC already during the conversion of pandas series to numpy arrays: https://pandas.pydata.org/docs/reference/api/pandas.Series.values.html

At the time of adding write support I noticed that the conversion to python `datetime` took quite some time... and so I wondered if it would be faster to convert...

In pull request #74 a test is added to check the result of an invalid where on amongst others a GPKG, and this indeed confirms this issue. If this issue...