Parmesh Krishen comments

Results 18 comments of


                                            Parmesh Krishen

Adding noAttributesWithArrayNotation option

This fell off of my radar. Code looks great and there's test coverage, so let's see if I can bring this in very soon.

Adding noAttributesWithArrayNotation option

Published! Thank you!

fix: propagate error

I think it may be better to hide this behind some configuration.

data prop is mutated, very poor implementation and React anti-pattern

+1 FWIW I tried to kindle a conversation around this with a rough draft of a PR before the maintainers transferred the repository and I didn’t get anywhere. https://github.com/storybooks/react-treebeard/pull/114

State mutation in readme example

💯 This is an excellent implementation of a tree view in React. I'd love to see the official example have the state contain `data` and also not mutate the state....

Support an `"engines"` field in `package.json`

Related: It looks like [corepack is likely going to be removed from the node distribution](https://github.com/nodejs/package-maintenance/pull/606).

Events

No worries! Sounds like fun. We’ve had a recent addition to the family, so time is short, but if I could I would.

templ fmt does not indent style tag properly

I think this does the same thing with `` tags - mainly the closing `` tags.