Ahmad Karimi

Results 35 comments of Ahmad Karimi

> Kindly ping @therealak12 Could you resolve what Sunjay mentioned. Thank you! Waiting for this: https://github.com/projectcontour/contour/pull/5802#discussion_r1443650964

![Screenshot from 2023-06-29 17-51-42](https://github.com/projectcontour/contour/assets/39967326/53360686-ea56-41c8-9700-c197429eafb7) Here is a demo of the current implementation. There were 2 httpproxies in the cluster with `example.com` and `example.com.ir` hosts at the time.

> Do we think users will need to configure this per-route stat prefix? Is there any value in making this configurable? If not we can probably get away with just...

@sunjayBhatia Does it look good to you? ![image](https://github.com/projectcontour/contour/assets/39967326/fdc66663-79c6-4336-bce7-f895e7337941) Please don't worry about the prefix section for now. It is just a temporary thing that I put in place to make...

> This seems more usable and now does separate the stats for different route rules > > We'll have to figure out a stat prefix we can generate that can...

One point to add here, It's not that trivial to include the `matchCondition` in the stats. There are various cases such as regex, exact, and prefix match. To distinguish between...

As @sunjayBhatia pointed above, the per-route metrics are located at the highest level of the granularity pyramid: > do we need the granularity of per-Route rule stats So let's discuss...

@sunjayBhatia Based on the discussion, it seems providing per-virtual-host metrics is enough. I'd like to hear your thoughts on this.

> hey @therealak12, thx 4 ur work, any progress? Hey. I'm busy these days. I'll update this thread soon. We need to agree on some design decisions first. - I...

So I've just (force) pushed a new commit. If the `enableStatPrefix` configuration is true, it sets `stat_prefix` to `_`. This actually resembles the idea implemented in [pr#5539](https://github.com/projectcontour/contour/pull/5539). But as it...