markdown-resume icon indicating copy to clipboard operation
markdown-resume copied to clipboard

Move common template index.html and css files into "default" folder

Open tigerclaw-az opened this issue 12 years ago • 1 comments

I noticed that each of the /template/* folders have almost the exact same CSS and the exact same index.html file. Can these be moved into /templates/default and inserted into the template being used during generation?

Then each template folder would only contain the necessary CSS required to overwrite the common styling.

tigerclaw-az avatar Mar 19 '14 23:03 tigerclaw-az

They certainly could be moved. I've kept them separate up until now to keep each one encapsulated and dependency free - I didn't want changes to one to affect the others, the pdf rules in particular can be quite fiddly. Keeping them separate also makes the assetic build a little simpler with the phar system too (the phar script can make relative paths weird). But, now that we have more than 3 templates, it might be worth doing a little refactoring.

The asset collector does apply LESS to the styles, but I haven't yet updated the templates to take advantage of that. Perhaps it's time to make a few reusable components and extend a common set of rules and get the path stuff sorted out.

I'll leave this issue open and make a commit against it when I have a chance.

there4 avatar Mar 19 '14 23:03 there4