Thilo von Neumann

Results 124 comments of Thilo von Neumann

Hi @HanGuangXin! Happy new year! Unfortunately, you have to use `ex.run` (or `ex.run_commandline`) for everything to work. `ex.run` contains the code to set up the configuration and observers. `@ex.main` doesn't...

Hi @vnmabus! I seem to have overlooked your PR. I like the idea to use the `ast` module to parse the config scopes, especially because bugs related to the config...

When I try to run the testcases, I get the error `E NameError: name 'generate_tokens' is not defined`

GitHub doesn't let me re-run the checks. I clicked on the re-run button and it just disappeared without re-running the checks. The easiest is probably to push an empty commit,...

@vnmabus Agreed, if it makes your code significantly simpler, we can remove support for Python 3.7

I don't plan on upgrading the minimum requirements explicitly in a separate PR. The recent updates always happened as a byproduct of other changes, like this one.

Well, you are right. Are you going to open one?

I found one issue: ```python def fn(): a = 2 # valid python code get_function_body(fn) ``` gives ``` ('def fn(): a = 2 # valid python code\n', 1) ``` The...

I didn't find other issues, so I think it's ready to merge!

Hi @Gracecr! That is an interesting idea. I always looked at units as implied by the metric key (like the key is "distance" then the unit must be "meters"). Is...