mrustc icon indicating copy to clipboard operation
mrustc copied to clipboard

[WIP] Build via CMake

Open ataulien opened this issue 7 years ago • 12 comments

See issue #87.

This is WIP - Don't merge yet!

ataulien avatar Oct 21 '18 13:10 ataulien

@ataulien What is the progress with this? It seems like the checks are passing? Anything more to do?

dongcarl avatar Dec 03 '18 07:12 dongcarl

CMake isn't used by the CI system yet. The compiler itself builds fine, the standard libraries can be built as well, but there are some features in the original makefiles which I haven't ported over.

Edit: heh, it seems like I didn't push the latest changes. Let me do that quickly...

ataulien avatar Dec 03 '18 08:12 ataulien

@ataulien I think as long as mrustc and minicargo builds fine with cmake, there could be a separate PR for the rest?

Just wondering what's missing and how I could help.

dongcarl avatar Dec 03 '18 08:12 dongcarl

@ataulien Travis isn't happy

dongcarl avatar Dec 08 '18 10:12 dongcarl

@dongcarl It seems to just hand at some point while ninja runs. I'll have a look at it tomorrow or so.

ataulien avatar Dec 09 '18 17:12 ataulien

"Tomorrow" is today and I got the build working on travis. Turns out using make instead of ninja and getting rid of set -e makes it work.

It builds mrustc and minicargo just fine, but still fails at compiling the rust std-libraries.

ataulien avatar Dec 18 '18 19:12 ataulien

If you make rust_libpanic_unwind and rust_libtest depend on rust_libstd then the standard library should compile.

Also, libproc_macro is a custom crate, its source is in lib/libproc_macro

thepowersgang avatar Dec 22 '18 00:12 thepowersgang

@ataulien Any more progress on this? What's missing now?

dongcarl avatar Jan 19 '19 03:01 dongcarl

The referenced issue has been closed; is this needed anymore?

rdrpenguin04 avatar Aug 04 '23 19:08 rdrpenguin04

Probably not needed? I feel that cmake is a little too much complexity to manage over just having a vsproject and makefile.

thepowersgang avatar Aug 05 '23 02:08 thepowersgang

I think I'll note that I would love to see meson - makes it easier to integrate in some build system stuff I tend to tinker with (Flatpak, freedesktop-sdk)

orowith2os avatar Sep 24 '23 00:09 orowith2os

I think I'll note that I would love to see meson - makes it easier to integrate in some build system stuff I tend to tinker with (Flatpak, freedesktop-sdk)

If mrustc gets a unified build system, it'd most likely be cmake - because cmake is already needed for llvm, and because I use it for my day job.

thepowersgang avatar Sep 25 '23 03:09 thepowersgang