thepoly
Gallery changes
Related Issues #93
Describe the Changes Implemented lightbox2 javascipt to allow arrow key functionality for galleries as well as better background blurring and user prompting. This is applied to featured photos, galleries, and any inline photos.
Still To Do Nothing.
Problems If the javascript doesnt properly execute (which i havent had happen to me) clicking on the images will redirect to the images direct link.
Testing checked articles that contain every combination of featured photo, galleries, and inline photos. As well as articles that contain none.
getting this error while running tests, cannot figure out why. Any help would be appreciated.
ValueError: Missing staticfiles manifest entry for '/js/lightbox.js'
We shouldn't include the raw lightbox.js file in the repo, instead it should be included with webpack similar to how stimulus.js is included
I have made changes to the js file in order for it to work with pipeline.
We should treat libraries as a black box, that way we can keep them up to date, manage them with npm/webpack, and swap them out with equivalent or similar libraries if need be. Additionally if we merge in a large js blob like this we will have a much more difficult time pinning down any bugs that may arise, especially if they don't appear in our source code.
If you need functionality the library doesn't provide, you can add the code into the pipeline source to make the modification.
Added the changes requested, the command that is failing in the build is working on my machine and could not find a solution for.