route icon indicating copy to clipboard operation
route copied to clipboard

Fix psr/simple-cache version constraint. Fixes #320

Open arabcoders opened this issue 3 years ago • 14 comments

Widen psr/simple-cache version constraint to support 1.0|2.0|3.0. Fixes #320

arabcoders avatar Dec 24 '21 17:12 arabcoders

Sorry for the delay on this, will be merging and tagging early next week.

philipobenito avatar Jan 14 '22 23:01 philipobenito

This actually causes an issue on PHP 8 as there is a method signature change

philipobenito avatar Feb 02 '22 09:02 philipobenito

This actually causes an issue on PHP 8 as there is a method signature change

Hmm.. im using this in my composer.json

{
    "require": {
        "psr/simple-cache": "3.0 as 1.0",
    }
}

and not getting any errors from router or anything and i have error_reporting set to E_ALL and running PHP 8.1

arabcoders avatar Feb 02 '22 09:02 arabcoders

What was the error? The logs for the tests have been removed already :\

sneakyvv avatar Sep 29 '22 08:09 sneakyvv

What was the error? The logs for the tests have been removed already :\

locking dependency on 1.0 causes conflicts as a lot of packages have moved on to 3.0

arabcoders avatar Sep 29 '22 21:09 arabcoders

So what's the plan for this @philipobenito, can't these other dependencies be updated/upgraded as well?

sneakyvv avatar Sep 30 '22 06:09 sneakyvv

This actually causes an issue on PHP 8 as there is a method signature change

@philipobenito, sorry to push for this again, but can you elaborate, so we can move away from the 7-year old dependency?

sneakyvv avatar Jan 05 '23 10:01 sneakyvv

@philipobenito I investigated it myself, and understand the issue now. To be able to fix this, support for PHP7 needs to be dropped, which is what #327 is about.

sneakyvv avatar Jan 05 '23 12:01 sneakyvv

No takers?

sneakyvv avatar Jan 26 '23 07:01 sneakyvv

Dealing with health issues, will get to it as soon as I can

Sent from Proton Mail for iOS

On Thu, Jan 26, 2023 at 07:42, Bart Vanderstukken @.***> wrote:

No takers?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

philipobenito avatar Jan 26 '23 07:01 philipobenito

Oh sorry to hear that, take care!

sneakyvv avatar Jan 26 '23 08:01 sneakyvv

@philipobenito did you have a change to look at this?

sneakyvv avatar Mar 29 '23 10:03 sneakyvv

any updates to this?

rikgirbes avatar Sep 29 '23 07:09 rikgirbes