oauth2-server icon indicating copy to clipboard operation
oauth2-server copied to clipboard

Use fragment for error response on implicit grant

Open hafezdivandari opened this issue 3 years ago • 3 comments

According to RFC 6749 on error response of the implicit grant, the authorization server should add parameters to the fragment component of the redirection URI.

It's already done for access token response on this line, But not for error response. this PR fixes this issue.

PS: This PR also adds $queryDelimiter property to OAuthServerException class to be used on generateHttpResponse() function. The reason behind this is we know if we should use fragment or not when initiating/throwing the exception but not when generating response.

hafezdivandari avatar Sep 08 '22 22:09 hafezdivandari

Please can you provide some information about why you want to add this change? Thank you

Sephster avatar Sep 08 '22 22:09 Sephster

I added description I hope it is clear enough.

hafezdivandari avatar Sep 08 '22 23:09 hafezdivandari

Just merged master into this and resolved conflicts.

hafezdivandari avatar Mar 29 '24 17:03 hafezdivandari