oauth1-client icon indicating copy to clipboard operation
oauth1-client copied to clipboard

Switch Twitter urlAuthorization to 'authorize'

Open ttomdewit opened this issue 7 years ago • 3 comments

When working with Socialite I noticed the callback URL for Twitter was wrong, at least for me. This PR aims to fix that.

I read your contributing guide but failed to find any existing tests to test Twitter. I'd be more than happy to work with you to make this a useful contribution and I thank you for your time and effort.

ttomdewit avatar Jun 23 '17 20:06 ttomdewit

@ttomdewit apologies for how stale this PR is. The project has been in hiatus for a few years now but we're working on a rewrite.

The /oauth/authorize endpoint aims to be an alternative to the /oauth/authenticate endpoint - both are used for retrieving a verifier token which can be in turn used for retrieving token credentials.

I think we could look to possibly support both endpoints within the Twitter provider based on configuration. I'll look at doing that in #111 and close this PR once that's been implemented.

bencorlett avatar Sep 02 '20 22:09 bencorlett

Hello @bencorlett, We're using laravel/socialite too, and since a few days, we have an issue on the /oauth/authenticate endpoint (infinite loop during oauth process). Other users have the issue too, and switching to the /oauth/authorize endpoint fix the issue.

Here is the bug ticket on Twitter : https://twittercommunity.com/t/infinite-redirect-loop-during-oauth-process/184086

Is it possible to take a look? Thank you.

Diegslapasteque avatar Feb 01 '23 08:02 Diegslapasteque

Ooooh thank you so much @Diegslapasteque ! We are experiencing the same issue since few days and just notice this workaround. Hope the team will quickly validate your PR 🙏

cmoreau avatar Feb 01 '23 08:02 cmoreau