flysystem-aws-s3-v3 icon indicating copy to clipboard operation
flysystem-aws-s3-v3 copied to clipboard

Uncaught S3Exception from s3Client->execute() in League\Flysystem\AwsS3v3\AwsS3Adapter->getRawVisibility()

Open mirie opened this issue 8 years ago • 0 comments

In League\Flysystem\AwsS3v3\AwsS3Adapter, it looks like in many methods, such as setVisibility(), $this->s3Client->execute($command); is wrapped in try catch blocks.

Is it OK to wrap the execute call in League\Flysystem\AwsS3v3\AwsS3Adapter->getRawVisibility() (Line: 485) as well? And, if there's an exception, return false.

mirie avatar Oct 14 '16 15:10 mirie