Pascal Schilp

Results 170 comments of Pascal Schilp

You're likely importing something from `semantic-dom-diff`, which leads to an import of `@web/test-runner-commands`, which uses a virtual module called `__web-dev-server__web-socket.js`. The file does not exist, so webpack crashes on it....

I happened to work on this recently, and its not really possible because uvu automatically kicks off test execution as a side effect of the module, and uvu only logs...

Adding package exports is usually if not always a breaking change

Can yu clarify the issue? This CEM output looks correct to me.

> Any ideas or pointers on how to solve this? I recommend creating a minimal reproduction, that usually highlights the issue pretty quickly.

There still seems to be quite a lot going on in the rollup config, can you try reducing that even more?

We set `generatedFiles` in this callback that is being added to `htmlPlugin.api.addHtmlTransformer`: https://github.com/modernweb-dev/web/blob/40fa569e1077ddad2fbca43a9ce4762c167f99a6/packages/rollup-plugin-polyfills-loader/src/rollupPluginPolyfillsLoader.ts#L45 When using multiple outputs, I see that in the `generateBundle` hook, `generatedFiles` is `undefined`: https://github.com/modernweb-dev/web/blob/40fa569e1077ddad2fbca43a9ce4762c167f99a6/packages/rollup-plugin-polyfills-loader/src/rollupPluginPolyfillsLoader.ts#L112 I tried...

Thanks for the PR! This looks great. I've left a couple of comments, could you take a look at them?

Thats a good point. Do you see any opportunities of where this could be implemented for the other components as well? I'd be happy to take a PR for this...

seems like this was fixed in https://github.com/open-wc/open-wc/pull/2507