theotherphil

Results 125 comments of theotherphil

Fixed by https://github.com/image-rs/imageproc/pull/515

I don't think this is something we can easily support.

Debugging utils are fine for this crate, but I agree that this functionality is a bit too niche.

In several places we have comments in the following format to explain why an unsafe block is beneficial and why it is correct: https://github.com/image-rs/imageproc/blob/62401e87b4d1a56526e5ef5a88fc8af18280ec1b/src/binary_descriptors/brief.rs#L89 As you suggest, adding one here...

It’s a neat idea - I’d be curious as to what difference benchmarks show between the const bool and the runtime if statements.

Ah, cool. I suspected a completely predictable branch wouldn’t cost much.

Implemented in https://github.com/image-rs/imageproc/pull/572

There's still the issue of missing docs for code behind the display-window feature.

Addressed in https://github.com/image-rs/imageproc/pull/580