AerialViews icon indicating copy to clipboard operation
AerialViews copied to clipboard

German Translation

Open peat80 opened this issue 2 years ago • 11 comments

Describe the solution you'd like...

I would like to know if this project would accept translations.

I could translate the strings of this app into german language. But it would be wasted time if it will not get accepted. So the question is would you merge such a pr?

Thanks for your hard work making this great app. It is a must have for me on android tv. 😍

peat80 avatar Apr 08 '22 22:04 peat80

Yes, I'd be happy to accept translations - it's something that's been on the TODO list for quite a while!

Plus, I haven't got around to updating the README about contributions, etc.

Do you have experience creating the language resources for an Android app or do you need my help to set it up?

Also, as the app is still under development, I might need new translations or updates in the the future if you're able to help.

theothernt avatar Apr 09 '22 09:04 theothernt

Okay that is cool. I will make a german translation when i have the time and then try to do a pull request when ready. If strings change in the future or new strings will be added i will try to keep german strings up to date in the future. 😀👌

peat80 avatar Apr 09 '22 10:04 peat80

That sounds great - thank you!

And just in case you need it, here is the official user guide on how to translate text resources in an Android app.

theothernt avatar Apr 11 '22 11:04 theothernt

Please have a look at #53 if this is okay. Have done this with a normal text editor on phone cause i have no android studio.

peat80 avatar Apr 11 '22 16:04 peat80

Give me a day or two to look at it 👍🏻

theothernt avatar Apr 12 '22 09:04 theothernt

A friend just had a quick look and suggested a couple of changes - let me know what you think?

After that, we should be good to merge!

theothernt avatar Apr 13 '22 12:04 theothernt

v1.2.2 is finally out which includes the German translation. I've added a small credit in the release notes but I do hope to add all contributors to the README at some point!

Also, I did find some hard-coded text strings that are not in the strings.xml ... so I may contact you soon about that 😅

theothernt avatar Apr 23 '22 15:04 theothernt

Have installed the update now. 😃👌 There are just are a few bits untranslated. If you add them to the strings.xml in the future we (or i) will get them translated for sure. 😎

peat80 avatar Apr 23 '22 16:04 peat80

I might ask you to take a look at some of the English -> German strings again in the next week or so as I hope to add all the remaining app text into localisable strings.

theothernt avatar Aug 26 '22 15:08 theothernt

Sure, sounds good. 😎

peat80 avatar Aug 26 '22 20:08 peat80

Thanks for that update @peat80. I still have more text changes to make but I think I'll just ship the current update (soon) as-is.

theothernt avatar Sep 12 '22 10:09 theothernt

Sorry to ask again, but if you have some free time, there are a load of new text strings in the app due to a complete re-organisation of the menus. Big changes to the text should be very rare! 😅

theothernt avatar Feb 21 '23 13:02 theothernt

Sure, i will have a look. Have already installed the new version yesterday. Great update btw. 😎👌

Should have time to look at the new strings in a few days. 😀

peat80 avatar Feb 21 '23 16:02 peat80

Finished updating the strings.

peat80 avatar Feb 26 '23 19:02 peat80

Thanks again for updating the translation - I'm hoping to add the remaining strings into resource files soon-ish.

theothernt avatar Mar 06 '23 15:03 theothernt

Quick question for you - do you know what happens when a language is requested (eg. German) but there is no text or resource for that language, does it default to English?

theothernt avatar Mar 20 '23 16:03 theothernt

Ah, I think I see it now - it helps to look at the filesystem and not the file list in Android Studio.

/values and /raw are the default so if openrawresource() is called and the file for the current locale doesn't exist, I think strings.xml or values.xml is returned and not /values-de/strings.xml

theothernt avatar Mar 20 '23 16:03 theothernt

If you have some free time, would you be interested in translating the POIs for the new Community videos?

theothernt avatar May 05 '23 13:05 theothernt

Where is that file located? 🤔

peat80 avatar May 05 '23 15:05 peat80

Where is that file located? 🤔

Here you go...

comm1_strings.json

comm2_strings.json

Also, the language can be switched in the latest build for testing.

theothernt avatar May 05 '23 15:05 theothernt

Is see. Maybe i can find the time to do this over the weekend. 🤔 😀

peat80 avatar May 05 '23 21:05 peat80

Translations should be up to date again. Hope we can see them in a new release soon. 😃

peat80 avatar May 07 '23 16:05 peat80

Translations should be up to date again. Hope we can see them in a new release soon. 😃

Thank you so much! I'm hoping to have that update out in the next week or so.

theothernt avatar May 07 '23 17:05 theothernt

I've added a few more new strings that need translation when you have some spare time?

theothernt avatar Jun 22 '23 15:06 theothernt

I'll try to have a look at it soon.

peat80 avatar Jun 22 '23 19:06 peat80

I'll try to have a look at it soon.

Thank you once again for your help with the translation 🥳

theothernt avatar Jun 26 '23 12:06 theothernt

when you have time, there are 10 new videos in the comm2_strings.json that need translation?

(you can ignore the app strings for the moment as more changes are coming in the next release so I might ping you in a few weeks about them)

theothernt avatar Sep 07 '23 12:09 theothernt

Added the missing video strings.

Will do app strings after you say they are ready. 😀

peat80 avatar Sep 10 '23 14:09 peat80

Added the missing video strings.

Will do app strings after you say they are ready. 😀

Thanks again, I'm hoping to add a lot more text in 1.5.2 🥳

theothernt avatar Sep 12 '23 09:09 theothernt

Ok, I've finally added all (I think?) text from the app into resources - and it's ready to be translated when you have time :)

theothernt avatar Oct 31 '23 16:10 theothernt