theos.dev icon indicating copy to clipboard operation
theos.dev copied to clipboard

Bump deps to remove sass in favor of sassc

Open L1ghtmann opened this issue 1 year ago • 2 comments

What does this implement/fix? Explain your changes.

  • See title

Does this close any currently open issues?

  • Attempts to resolve https://github.com/theos/theos/actions/runs/9827264992/job/27133441992

Any relevant logs, error output, etc?

Any other comments?

  • Currently fails with
sprockets-4.2.1/lib/sprockets/path_utils.rb:111:in `initialize': no implicit conversion of nil into String (TypeError)

      start, dest = Pathname.new(start), Pathname.new(dest)

which I think is because I'm using WSL? Pr'ing now to test ....

Where has this been tested?

Operating System:

Linux (WSL)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

L1ghtmann avatar Jul 07 '24 19:07 L1ghtmann

Deploy Preview for theos-site failed.

Built without sensitive environment variables

Name Link
Latest commit f2244d83f2ac73fda0bff756d8c4302bbfa804f0
Latest deploy log https://app.netlify.com/sites/theos-site/deploys/668af0e221664a0008b3c35a

netlify[bot] avatar Jul 07 '24 19:07 netlify[bot]

Note to self: the root issue seems to spawn from jekyll-assets being borked and unmaintained. Specifically, it looks like v4 of sprockets dependency changed core behavior of something, causing build issues.

sprockets < 4.0.0 works for theos.dev's build but doesn't allow for the newer jekyll-assets. This is problematic as the newer version of one of these (forgetting which now ... whoops) does away with the sass dependency, which looks to have caused the Netlify build to fail, in favor of sassc.

Current attempts at resolving without modifying our source are present at https://github.com/L1ghtmann/jekyll-assets. Not sure how feasible trying to maintain support for an old, complex gem is.

Relevant ref commit:

  • https://github.com/envygeeks/jekyll-assets/commit/a920ab19777bce21039a5e5be9fdc7f70e8bd6c4

L1ghtmann avatar Jul 08 '24 01:07 L1ghtmann