templates icon indicating copy to clipboard operation
templates copied to clipboard

Published 20 hours ago • verified publisher icon theos

Update SwiftUI application to match UI of other templates

Open donato-fiore opened this issue 2 years ago • 5 comments

What does this implement/fix? Explain your changes.

This PR adds a application_swiftui template.

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

No

Any other comments?

No

Where has this been tested?

Operating System: WSL - Ubuntu 20.04.5

Platform: Linux

Target Platform: iOS

Toolchain Version: Latest

SDK Version: iOS 14.5

donato-fiore avatar Oct 22 '22 14:10 donato-fiore

Bruh

Luki120 avatar Oct 22 '22 19:10 Luki120

:trollface:

iCrazeiOS avatar Oct 22 '22 22:10 iCrazeiOS

lgtm 🤝

Evelyneee avatar Oct 22 '22 22:10 Evelyneee

As Luki120 noted, this is somewhat a duplicate of #24 (which is now merged). I like that this PR has a UI that matches the other two ios/application templates. This PR also exposes the small discrepancy that

https://github.com/theos/templates/blob/27e775431377693b9f9e4494cf889d643345461a/ios/application_swiftui/Makefile#L4

should be include @@THEOS@@/makefiles/common.mk in this repository.

I think we can either re-purpose this PR to adjust the Makefile and ContentView, or close this PR. @donato-fiore What do you think?

leptos-null avatar May 18 '24 22:05 leptos-null

I agree that repurposing the PR would be beneficial.

L1ghtmann avatar May 25 '24 03:05 L1ghtmann