pgtap icon indicating copy to clipboard operation
pgtap copied to clipboard

Change pgtap_version() from numeric?

Open decibel opened this issue 4 years ago • 2 comments

Now that we're past 1.0.0, it'd be helpful to be able to do patch releases (ie, to fix issue #209). We can't do that with pgtap_version returning numeric, unless we want to have it return something like 1.001?

decibel avatar Sep 16 '19 21:09 decibel

PGXN supports only semantic versions, so 1.001 is not allowed.

theory avatar Sep 17 '19 14:09 theory

Sorry, was reading too quickly. Please don't change its return value, that would break compatibility. The value is set by the $NUMVERSION variable in the Makefile. I think the idea was that it would return only the first two parts of the version, because the patch version (the third part) should indicate only the simplest of bug fixes, without changing any functionality. But also, we've never released a version with anything other than 0 in the version patch level. So maybe just stick to that pattern and release 1.1.0?

theory avatar Sep 17 '19 14:09 theory