pgtap icon indicating copy to clipboard operation
pgtap copied to clipboard

add function_checksum_is

Open marco44 opened this issue 6 years ago • 8 comments

Hi, As discussed in theory/tap-parser-sourcehandler-pgtap#18, here is a PR to add function_checksum_is

I didn't like joining to pg_proc, but couldn't find a better idea without extending tap_funky.

marco44 avatar Feb 03 '18 10:02 marco44

I wonder... With pgTAP, shouldn't one be checking the behavior of a function?

This seems more like an audit rule than test assertion.

cbandy avatar Feb 03 '18 14:02 cbandy

Awesome, care to add some tests to test/sql/functap.sql?

theory avatar Feb 03 '18 17:02 theory

@cbandy pgTAP has no religion about the type of testing you do, but likes to give you the tools to do your testing well.

theory avatar Feb 03 '18 17:02 theory

Took me a while, but here it is :)

marco44 avatar Feb 27 '18 16:02 marco44

Look unhappy on Postgres 10. :-(

theory avatar Feb 27 '18 16:02 theory

Yes but is seems to fail on partitions… which I didn't touch...

marco44 avatar Feb 27 '18 17:02 marco44

Please merge master; it has fixes for some bugs as well as much better test capabilities.

nasbyj avatar Nov 14 '19 00:11 nasbyj

Also, this needs documentation.

nasbyj avatar Nov 19 '19 19:11 nasbyj