David E. Wheeler

Thanks for the PR. If you don't mind: * Please squash this down to a single commit * Remove all AI junk: reviews, unreviewed code Thanks!

> What does this mean? Do you want me to remove the reviews on this page? Happy to squash to a single commit, but I'm unsure of what you're asking...

Huh, some error is failing to be thrown because it's missing an error message. Can you apply this patch, try again, and paste the output? It will add a stack...

Thank you. Looks like something in the `connected` callback is failing but not propagating an error: https://github.com/sqitchers/sqitch/blob/138658889f824eaf59abd5fff96c46ff6f4842a5/lib/App/Sqitch/Engine/oracle.pm#L106-L119 Super weird. Can you run those queries manually and see which if any...

And by queries I mean: ```sql ALTER SESSION SET nls_date_format ='YYYY-MM-DD HH24:MI:SS TZR'; ALTER SESSION SET nls_timestamp_format ='YYYY-MM-DD HH24:MI:SS TZR'; ALTER SESSION SET nls_timestamp_tz_format ='YYYY-MM-DD HH24:MI:SS TZR'; ALTER SESSION SET...

Interesting. I guess those have been removed in some version of Oracle? It's still [documented in Release 23](https://docs.oracle.com/en/database/oracle/oracle-database/23/refrn/NLS_TIMESTAMP_FORMAT.html) and listed in the [autonomous database docs](https://docs.oracle.com/en/cloud/paas/autonomous-database/serverless/adbsb/autonomous-initialization-parameters.html). If you comment out those...

Oh, it doesn't like the date format. What happens if you omit ` TZR`?

Or perhaps this patch: ```patch --- a/lib/App/Sqitch/Engine/oracle.pm +++ b/lib/App/Sqitch/Engine/oracle.pm @@ -105,10 +105,10 @@ has dbh => ( Callbacks => { connected => sub { my $dbh = shift; - $dbh->do("ALTER...

Hi @Mouad-El-Asri, have you had a chance to try this patch?

Yeah. In general I want the pre-warm, though it doesn't matter so much in a test. But there ought to be some way for the error to propagate. I thought...