theoreticalbts
theoreticalbts
First of all, the intent of this ticket was to task myself (or whoever decided to pick it up) to _CREATE A UNIT TEST_ for how much interest short positions...
Commit addb736d7c0203625b34e303d16f759ec57367bf is highly relevant (despite referencing another issue in the commit message). It makes the "plus ten percent" rule only apply to margin calls, not expired positions.
Internally shorts are on the bid side and margin calls are on the ask side, so internal is backwards relative to what you're saying. Basically the front runner uses his...
There's also the question of how this will interact with black swans. Suppose I short $300 at $0.03 / XTS with 20,000 XTS, initial collateral (including buyer's 10,000 XTS) would...
> If no order can match only in the current pass, does this need to be a continue rather than a break There are actually two loops. The inner loop...
The TODO at [market_engine.cpp#L57](https://github.com/BitShares/bitshares/blob/29064038e46db60241a2e3af02ec1c3a743a25f6/libraries/blockchain/market_engine.cpp#L57) was a reminder to myself to review corner cases in the iterator logic. I'm replacing it with a comment containing my analysis, see f6d2d56f78b964c964e3025c21e563f562a26c2c The TODO...
About flagging [chain_database.cpp#L2347-L2474](https://github.com/BitShares/bitshares/blob/29064038e46db60241a2e3af02ec1c3a743a25f6/libraries/blockchain/chain_database.cpp#L2347-L2474) as a potential trouble spot -- nice code reviewing skills. @valzav yesterday reported a failing acceptance_test which, upon investigation, I determined to be failing due to incorrect...
@abitmore : `_short_at_limit_itr` is a reverse iterator so it starts at feed price and goes downwards (but excludes orders exactly at the feed price, those are covered by `_short_at_feed_itr`). When...
We should sign release sha256sums and Git commit hashes, and publish it as `public_data` from some official account. So anyone with access to the blockchain can verify a given source...
GPG is a major PITA to use. I understand how to use BitShares -- indeed it is trivial for anyone with a BitShares account to publish stuff in `public_data` --...