vue-chat-scroll
vue-chat-scroll copied to clipboard
theomessin
Convert plugin to Vue 3 and added Typescript declaration
This is just an update based off the changes indicated here.
I can set up a simple test case with Vue3/Vite after work. The pause feature seems to break in this case so I'll look into it.
@Jaspur I would consider this PR incomplete because it doesn't resolve the pause issue. If you want to use it in the incomplete state you can clone the changes locally and install via npm install <folder> I will try to fix the pause bug when I have the time.
@Jaspur I would consider this PR incomplete because it doesn't resolve the pause issue. If you want to use it in the incomplete state you can clone the changes locally and install via
npm install <folder>I will try to fix the pause bug when I have the time.
You can also try npm i git://github.com/chmking/vue-chat-scroll#next .
Or you can use the commit hash npm i git://github.com/chmking/vue-chat-scroll#1188ac24
@chmking I'd probably be happy to merge this, although it'd be version 1.5.0 as I'll be introducing proper SemVer in version 2 (coming soon™)
@theomessin So, I've fixed the pause functionality with Vue 3.x and supported the CDN script import with examples for Vue 2.x and 3.x. This should support backwards compat with both versions of Vue and make the 1.5.0 version more reasonable.
One thing to mention, the README is not entirely correct now. It might be worth adding documentation for both Vue versions. Thoughts?
@chmking Sounds like a plan! I'll review the PR once you've added that 😄
@Jaspur You should already have access to the code from my branch and the method for pulling it was described. If you need it to be from the primary repo you'll need to wait until I have the time to finish up the PR. I'm very busy with work.
I think this should be sufficient for the setup instructions. Let me know if you need anything else for the PR; otherwise I'd consider this resolved and ready for merge.
