Théo FIDRY

Results 764 comments of Théo FIDRY

Checking this issue again, it may not be as big of a deal as I make it out to be. Currently there is a lot of exposed symbols due to...

Unfortunately it is expected to some degree. It is hard to detect what string can and cannot be scoped so there is bound to be cases of strings incorrectly scoped...

The coveralls one? I don't have access to it: https://coveralls.io/github/vincentchalamon/PostmanGeneratorBundle?branch=master Neither do you have a coveralls config file :/ Or did you mean to create one?

@vincentchalamon should do the trick... But is there any reason not using Scrutinizer instead? Coverage badge: [![Coverage Status](https://coveralls.io/repos/vincentchalamon/PostmanGeneratorBundle/badge.svg?branch=master&service=github)](https://coveralls.io/github/vincentchalamon/PostmanGeneratorBundle?branch=master)

Hm you should still give it a try I'm using a free version. Maybe they did change their policy but it would be surprising.

An example of config: [`.scrutinizer.yml`](https://github.com/theofidry/PsyshBundle/blob/master/.scrutinizer.yml). But likely to update the PR a bit later though, it's getting a bit late^^

The CS of the other files is addressed in https://github.com/thephpleague/oauth2-server-bundle/pull/141.

@chalasr ready (beware it does require you to update the repository settings to add the "tests status" job as a required job for the `master` branch