node-google-spreadsheet icon indicating copy to clipboard operation
node-google-spreadsheet copied to clipboard

Delete Dimension

Open ahmedrizwan239 opened this issue 1 year ago • 9 comments

Implementation of the deleteDimension api call.

ahmedrizwan239 avatar Sep 08 '23 12:09 ahmedrizwan239

nice! Thanks :D

To make the DX slightly easier, I think I might

  • make 2 methods deleteRows and deleteColumns - this could be in addition to deleteDimension, and could just call deleteDimension internally
  • unwrap the start/end params from the object (ie deleteRows(start, end)) but be sure to handle the undefined case (google's api lets you have it unbounded on one side)

It's all fairly subjective, but it's sort of the fun part in trying to design a more intuitive interface for users than google's apis, which is what this module is all about.

Also we'll need to add tests and docs before merging. Feel free to continue, or leave it as is and I'll add the rest before merging.

Cheers and thanks!

theoephraim avatar Sep 08 '23 16:09 theoephraim

Can you please merge this asap? I need to use it in my package for a project. This would help, Thanks!

ahmedrizwan239 avatar Sep 09 '23 07:09 ahmedrizwan239

Agree, could this be merged please?

cesar3030 avatar Dec 01 '23 18:12 cesar3030

This will work great in my project! Could this be merged please?

fernandohg97 avatar Jan 09 '24 18:01 fernandohg97

Could definitely use this on a project I'm working on, is there any way we could get this merged soon?

TRMoosee avatar Jan 12 '24 22:01 TRMoosee

Could use this as well!

ururk avatar May 15 '24 13:05 ururk

@theoephraim It looks like some changes you suggested still need to be done... should I fork @ahmedrizwan239 fork or make my own?

ururk avatar May 15 '24 13:05 ururk

@ururk - yeah if you're up for it, got for it! The functionality itself is pretty simple, but need to add tests, docs, and ideally make the DX a little simpler... Otherwise I'll try to get to it asap

theoephraim avatar May 15 '24 16:05 theoephraim

I'm taking stab at it, hopefully have something for today. I have the two additional methods written and was looking at your tests

ururk avatar May 15 '24 16:05 ururk