node-google-spreadsheet icon indicating copy to clipboard operation
node-google-spreadsheet copied to clipboard

Separate auth from library

Open LeGmask opened this issue 3 years ago • 2 comments

The idea is to create another package (or just use something that already exist) and separate the auth from this module. Since this package is fully Javascript (browser) and nodejs compliant why keep a package that break the compatibility for Javascript (browser) support ....

I currently use this project in a webapp without backend and no other solution than patching (by removing google-auth) to finally have webpack successfully compile ...

Anyway good jobs, that's a nice project. Best regards

LeGmask avatar Dec 31 '21 14:12 LeGmask

It's been on my to-do list for a while. I think the best way would be to use rollup to create 2 different builds, one for the browser and one for backend. But currently since there is no build process at all, it's a bit of a project... I'll see if maybe there is a simpler way as you suggest to just remove the google auth library, but I do like keeping the DX as simple as possible for most users.

theoephraim avatar Jan 21 '22 16:01 theoephraim

Yeah, In fact I've allready removed google auth for my project and that's work well : https://github.com/LeGmask/node-google-spreadsheet

But yeah the auth wrapper is pretty good and simple tho. I understand the idea to keep it simple and I'm fully agree with you since I use this library because of is simplicity since all the others libs are horrible to use ...

LeGmask avatar Jan 22 '22 14:01 LeGmask

@LeGmask - I just finally released a typescript rewrite with many improvements and one of them was decoupling the google-auth-library. Thanks so much for the suggestion and discussion.

Cheers!

theoephraim avatar Jun 26 '23 08:06 theoephraim