electron-boilerplate icon indicating copy to clipboard operation
electron-boilerplate copied to clipboard

Windows installer app filename

Open edriang opened this issue 8 years ago • 5 comments

Name given in build-config.json must match package.json from root directory (not sure if the one inside the /app directory too).

The problem was that once installed shortcut icon pointed out to wrong .exe file path, because of this difference between names in package.json and build-config.

It would be nice to correct this issue, or at least leave it clear in the docs.

Excellent library BTW

edriang avatar Oct 24 '16 20:10 edriang

@edriang Thanks for the feedback, will look into it!

TristanPouliquen avatar Oct 25 '16 20:10 TristanPouliquen

@edriang Hello,

Tried to look in your issue but as I changed computer, I have to reinstall everything and I don't have my former rights to update directly this repository ;)

Could you dig a bit further and test the different cases ? (changing the names in package.json, build-config.jsonand app/package.json)

The ideal would then be to do a pull request on this repo, I'll take on myself to contact someone for Theodo that can review/validate it!

Thanks by advance :)

TristanPouliquen avatar Oct 26 '16 19:10 TristanPouliquen

Hey @TristanPouliquen! OK, no problem, will try to take a look on it and give feedback.. But maybe the next week or the other, because currently I was moved to another project until some new definitions arrive. Thank you for your interest!

edriang avatar Oct 28 '16 13:10 edriang

+1

minasvisual avatar Oct 20 '17 05:10 minasvisual

@minasvisual

As I had responded to edriang before, I don't have the rights anymore on this repository (I have left Theodo since then), and as it is not one of the common technologies used by them, I sadly think that they are not interested in maintaining this repository any longer.

I would advise you to fork and try investigating on your own. Best of luck!

TristanPouliquen avatar Oct 20 '17 19:10 TristanPouliquen