LLPhant icon indicating copy to clipboard operation
LLPhant copied to clipboard

functionResult messages missing 'name' parameter with OpenAI

Open kaeldric opened this issue 1 year ago • 4 comments

Adding message of type "functionResult" did not work in OpenAI chat because the parameter 'name' is required. I could not test the fix with other models.

kaeldric avatar Aug 05 '24 21:08 kaeldric

Hi @kaeldric , can you provide any integration and unit tests?

f-lombardo avatar Aug 06 '24 08:08 f-lombardo

hey @kaeldric, thanks for your contribution! If you can add test that would be amazing or maybe some example code in the doc to show the usage?

MaximeThoonsen avatar Aug 06 '24 09:08 MaximeThoonsen

Hi all! I wrote some tests based on my current usage, I don't know if those work for you.

About the documentation, what do you think about the Integration/Chat/OpenAIChatTest.php function? I can try to elaborate on that with the idea of providing additional context to the assistant with the result function, maybe checking the result function value.

kaeldric avatar Aug 08 '24 09:08 kaeldric

@kaeldric maybe we can use CalledFunction now it has been introduced?

MaximeThoonsen avatar Sep 04 '24 11:09 MaximeThoonsen