LLPhant icon indicating copy to clipboard operation
LLPhant copied to clipboard

fix #100 update deprecated constants in doctrine

Open JasonMartoux opened this issue 1 year ago • 5 comments

fix #100 deprecated constant Lexer for TokenType constant in doctrine/orm 2.19 see here

JasonMartoux avatar May 19 '24 18:05 JasonMartoux

Hey @JasonMartoux, I think we need to add support for multiple Doctrine version to make this works

MaximeThoonsen avatar May 19 '24 19:05 MaximeThoonsen

@MaximeThoonsen Hey ! The deprecation started at the version 2.19 of doctrine/orm. I've forked the repo yesterday (Omega good job by the way :+1: mate ), and got the issue. Maybe update the doc in the meantime ?

JasonMartoux avatar May 19 '24 20:05 JasonMartoux

Hey @JasonMartoux , Thanks for the kind words! Yes you are right, I will update the doc. Do you want to suggest a fix that works for many doctrine version?

MaximeThoonsen avatar May 21 '24 13:05 MaximeThoonsen

@MaximeThoonsen just fix the version in the composer file ?

JasonMartoux avatar May 21 '24 18:05 JasonMartoux

@JasonMartoux no because we want to let as many people as possible use it and they all have different version. We don't want to create a version conflict

MaximeThoonsen avatar May 26 '24 06:05 MaximeThoonsen

done here: https://github.com/theodo-group/LLPhant/pull/234

MaximeThoonsen avatar Oct 11 '24 15:10 MaximeThoonsen