bothan
bothan copied to clipboard
Bothan.io Bothan Deploy hangs on name with <=2 chars
following the bothan deploy from bothan.io to heroku currently hangs and does not create the app
repeated auto deploy and now it works fine. Seeing as I didn't capture any logs at the time this happened it's going to be hard to determine what (if anything) has changed, so closing this for now
Oh, that's very odd.
@agentGav was experiencing this as well. Gavin, do you mind retrying the bothan deployment as it's working here OK now?
Is it worth getting Airbrake here so we can track fails?
it works as long as the name is >= 3 chars spins on 2 chars (think it's a limit on heroku)
On 27 April 2017 at 12:48, James Smith [email protected] wrote:
@agentGav https://github.com/agentGav was experiencing this as well. Gavin, do you mind retrying the bothan deployment as it's working here OK now?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theodi/bothan/issues/201#issuecomment-297691386, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVvuxGVu3wUlgwnD1uw1aEcp9jsec_Rks5r0ICRgaJpZM4M1rxL .
-- http://www.dgen.net http://www.dgen.net/blog/overview/ || http://www.binarydust.org || @agentGav http://twitter.com/agentGav
AHA, ok. Trust you to find a degenerate corner case. We can add validation to the input field to make sure it's >=3 chars.
So I literally can't replicate this because so many 3 char combinations appear to trigger Application name $$$ is not available. I'll add the validation rule that @Floppy suggested, but I'm decreasing the severity of this because I think it's a hard to access edge case
I think the issue is with less than 3, so the validation should be enough.