horton icon indicating copy to clipboard operation
horton copied to clipboard

Use better int type than long in C++ code

Open tovrstra opened this issue 8 years ago • 4 comments

This is much clearer and is suggested by cpplint. This touches a lot of code, so it is best to wait till 2.2.0.

tovrstra avatar Jun 02 '16 12:06 tovrstra

what would happen than is one tries to run HORTON on a 32-bit system?

sfias avatar Jul 01 '16 15:07 sfias

It would work, not super efficiently. Should we care?

tovrstra avatar Jul 01 '16 17:07 tovrstra

@matt-chan We should rethink this. This is the detailed explanation and we interpreted too narrowly:

https://google.github.io/styleguide/cppguide.html#Integer_Types

It is probably better to ignore this problem until we have better idea how to handle this.

tovrstra avatar Jul 01 '16 21:07 tovrstra

For now, the corresponding check is disabled in tools/qa/trapdoor_cpplint.py. We can switch it back on after we decided how to deal with this.

tovrstra avatar Jul 01 '16 22:07 tovrstra