Selector icon indicating copy to clipboard operation
Selector copied to clipboard

[method.dissimilarity module]

Open FarnazH opened this issue 1 year ago • 3 comments

To do:

  • [x] Add test to reach 100% coverage
  • [x] Add comments in the code
  • [x] Add formulas to docstring and polish docstring (add reference).

FarnazH avatar Jun 12 '23 18:06 FarnazH

We need to put the references under the References field instead of Notes, which remains to be done.

FanwangM avatar Jul 06 '23 05:07 FanwangM

@maximilianvz, can you please revise the method.dissimilarity based classes to match the DirectedSphereExclusion class in terms of variable names and docstring format/wording?

FarnazH avatar Jul 26 '23 21:07 FarnazH

Hey @FarnazH @FanwangM when do you plan to merge the code changes so we can access the dissimilarity method? I was trying the Getting Started guide and couldn't use the dissimilarity method.

I am getting the error: ModuleNotFoundError: No module named 'selector.methods.dissimilarity'

After checking the issues and pr's related to it, I found that earlier it was present in DiverseSelector/methods/dissimilarity.py which no longer exists on the current main branch.

When will it get merged? If you need any help, I am willing to contribute! Thanks!

kunikachandra avatar Mar 06 '24 15:03 kunikachandra

The selector.methods.dissimilarity is now renamed as selector.methods.distance.

FanwangM avatar Jun 25 '24 15:06 FanwangM