ionic-tk-social-network
ionic-tk-social-network copied to clipboard
thenaim
Q&A
Hello @thenaim. This template app is really cool. I have some question about components, why you didnt make a component module instead?
@SnowBases, The main reason is the lack of free time (since I work) to implement this approach, but in the code I try to separate templates into components and modules (angular).
upd: There are plans for such an approach, but if you have a desire to work on it, we can organize it.
Hello @thenaim ,
Thank you so much for a great app. 👍
Could you please tell me how to run it and log in? I can build and run it by npm run start, but I don't know how to log in or register. Is there any demo account to use?
@nguoianphu, you can use any valid email address and a password of at least 6 characters
Thanks @thenaim, got it. I'm able to build & run it on web. I also can build it on Github action & generate APKs to Release. However, the app seems slow when running on Android...
@nguoianphu, Did you compile the production version of angular (ionic), and also compile for android (apk)? If not, then the application will be slow to work, as many plugins and helper functions in the dev version are running under the hood.
And also the application requires a lot of optimization, so if there is a desire to work on this, then welcome)
Yes, I've compiled it in production mode. Please check my Github action. BTW, I'm learning React & Ionic so I'm not interested in Angular. :) https://github.com/nguoianphu/ionic-tk-social-network/releases
@nguoianphu, I just checked the apk on a real device. It really works slowly, but as I wrote above, it is necessary to optimize the interaction with the server. Such as pagination, preloading modules, requesting the server after full rendering, etc. First of all, I will deal with this. Thank you.
I see you worked with github actions, do you want to work and do PR, where all this will be set up for this project? To configure action for all PR`s for main branch.
@thenaim , just see you added actions to deploy the web version automatically. It's great 👍 !
But it looks like we deploy the web version from main branch, instead of web. Does it make sense?
@nguoianphu, Thank you. This is done to avoid committing www changes to the main branch every time and the web version is always separated from the main branch. Or do you have an idea?
upd: In ionic, during development, the live version will be constantly launched, as well as with many options, so when sending a commit, there may be conflicts in the code (www folder). In this situation, you will need to compile locally and send a commit. Maybe I misunderstood, correct me.
@nguoianphu, I have a question for you, how we can optimize github actions? Can we somehow separate them, or into some stages? Any ideas?
@thenaim , exactly what I want to do. Please refer this, I like it and plan to apply: https://github.com/zyrouge/yukino-app/actions
@nguoianphu, Yes, this approach is very good. for example, first of all, run the code check (eslint), if no errors, then the rest of the actions. I think you already understood the concept.
@thenaim , can you register this repo to https://www.codefactor.io? Then we can have badge for it. If it's ok, I will open a PR for this commit.