laravel-langman
laravel-langman copied to clipboard
themsaid
Add Support for PHP 7.4
PHP 7.4 ternary operations works differently (ie. more explicit) with brackets.
Brackets are inserted wrongly as far as I can see. This seems like a harmful thing to do. Why would you insert closing brackets halfway the ternary operation? Clearly they should be around the whole ternary operator in this visibly formatted expression.
@muisit I'm using PHP 7.4 and trying to fix this issue. If you feel i am wrong, then i hope you can help fix it.
As I wrote, the closing parenthesis should be at the end of the expression, not halfway the ternary operator. You have a double closing parenthesis at line 115. Remove one and add it at the very end of that same line (but obviously before the semi-colon...).
Clearly the isset condition check belongs to the expression on that whole line. Where you added the closing parenthesis makes absolutely no sense.
