ibis icon indicating copy to clipboard operation
ibis copied to clipboard

Published 20 hours ago • verified publisher icon themsaid

Upgrade PHP 8.2 and packages

Open roberto-butti opened this issue 2 years ago • 11 comments

  • upgrade and check with PHP 8.2
  • upgrade code using new renderer of Commonmark
  • upgrade GitHub Actions workflow
  • using Pint with PSR12
  • added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)

roberto-butti avatar Dec 25 '22 09:12 roberto-butti

would be great to get this merged.

dcblogdev avatar Mar 06 '23 14:03 dcblogdev

  • upgrade and check with PHP 8.2
  • upgrade code using new renderer of Commonmark
  • upgrade GitHub Actions workflow
  • using Pint with PSR12
  • added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)

And adds support for Laravel v10

Can this be merged?

edwinheij avatar Mar 24 '23 21:03 edwinheij

@themsaid Can you please merge it?

sajaddp avatar May 14 '23 09:05 sajaddp

Good morning Mohamed @themsaid . I know you are super busy, and this project is great and very helpful. I would like to know if you have any plans to upgrade this wonderful project with the latest packages. I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

roberto-butti avatar Aug 01 '23 06:08 roberto-butti

Good morning Mohamed @themsaid . I know you are super busy, and this project is great and very helpful. I would like to know if you have any plans to upgrade this wonderful project with the latest packages. I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

I would love to offer my help as well! I love the tool, it has allowed me to publish 5+ books so far 🙏

image

bobbyiliev avatar Aug 01 '23 08:08 bobbyiliev

@roberto-butti can you release your fork? It would be amazing to have an installable version.

dcblogdev avatar Aug 18 '23 15:08 dcblogdev

@themsaid Any plan to have a quick review of this PR and merge. Thanks

CyberMullah avatar Sep 12 '23 10:09 CyberMullah

I'm available to publish the package from the forked repo, but i think is better and fair to wait Mohamed.

roberto-butti avatar Sep 12 '23 12:09 roberto-butti

In case someone wants to use the version that @roberto-butti

I've added a temporary working version here: https://github.com/thedevdojo/ibis

You can install with: composer global require thedevdojo/ibis

I will remove this package when it's no longer necessary and this gets merged in, but until then, you can use this version with the latest version of Laravel 😉

tnylea avatar Oct 10 '23 22:10 tnylea

Thank you @tnylea, Let's hope @themsaid sees the comments and merges the PR. :)

CyberMullah avatar Oct 11 '23 07:10 CyberMullah

Hi Folks, on top of this PR, i created the PHP8.3 Pull request. Based on the PHP 8.2 changes, PHP 8.3 doesn't introduce changes; just adjusted the GitHub Workflow for the CI just to check the PHP8.3 execution https://github.com/themsaid/ibis/pull/58

roberto-butti avatar Dec 03 '23 08:12 roberto-butti