cocotb-test icon indicating copy to clipboard operation
cocotb-test copied to clipboard

Timescale should also support fs

Open alexforencich opened this issue 1 year ago • 1 comments

The timescale parameter is currently checked with a regex like so:

if timescale is None or re.fullmatch("\\d+[npu]?s/\\d+[npu]?s", timescale):

Unfortunately, this regex is wrong as fs (femtoseconds) is also a valid timescale. Seems ms has the same issue. It's probably worth checking against relevant documentation to make sure this regex doesn't need to be updated again.

alexforencich avatar Sep 18 '23 00:09 alexforencich

Can you make PR? If not I will try to fix this.

themperek avatar Sep 20 '23 12:09 themperek