jquery-week-calendar icon indicating copy to clipboard operation
jquery-week-calendar copied to clipboard

events options : incorrect items in document

Open henrygotmojo opened this issue 12 years ago • 2 comments

Arguments of following "events" functions are incorrect:

====> reachedmindate: [function($calendar, date)] ====> reachedmaxdate: [function($calendar, date)]

The functions are now returning:

====> reachedmindate: [function(DomEvent, date)] ====> reachedmaxdate: [function(DomEvent, date)]

henrygotmojo avatar May 19 '12 15:05 henrygotmojo

The solution for this issue would be to follow the conventions used by jQuery UI for events. The events triggered by jQuery UI widgets have to arguments: the event itself and some data linked to it.

$( ".selector" ).bind( "dropcreate", function(event, ui) {
  ...
});

We already follow this convention for the beforeEventNew event. Of course, doing this for this particular case would break the BC... but as the current behavior is broken, is it a real problem?

Please review my PR for this issue before I merge it.

K-Phoen avatar May 20 '12 12:05 K-Phoen

Ping?

K-Phoen avatar May 25 '12 14:05 K-Phoen