kirki icon indicating copy to clipboard operation
kirki copied to clipboard

Adds an option to set a custom directory for the fonts folder.

Open EngKhaledB opened this issue 3 years ago • 1 comments

The issue:

For read-only hosting like Pantheon for example, they prevent php from writing any file outside uploads directory. So that, a lot of php errors happens because of no write permissions.

The Fix:

I added an option to set a custom fonts directory via constant variable named KIRKI_FONTS_DIR.

EngKhaledB avatar Feb 22 '22 16:02 EngKhaledB

Hi @EngKhaledB , good suggestion! I'm not sure if we should use constant or filter for that. What do you think @MapSteps ?

Oh, maybe we forgot to mention that this repo contains individual controls. The real developments are in the individual repositories. So this PR should be in kirki-framework/module-webfonts repository.

Thanks :)

contactjavas avatar Mar 01 '22 01:03 contactjavas