kirki icon indicating copy to clipboard operation
kirki copied to clipboard

Published 20 hours ago • verified publisher icon themeum

The field-dependencies JS implementation doesn't work

Open aristath opened this issue 7 years ago • 2 comments

Internally the previous implementation (via PHP) is used instead of the new field-dependencies module. This was working at some point, I have to see where/when it broke

aristath avatar May 08 '17 23:05 aristath

https://github.com/aristath/kirki/commit/84c881ab7b01c8a541497810e52d389d621acf67 partially fixed the issue. Now the JS implementation kicks in immediately so we don't have to wait for the ajax call in order to hide the control. However, if we completely deprecate the PHP implementation, as soon as the ajax call is made, the control gets shown no matter what because it defaults to __return_true. No time to investigate today so I'll leave it the way it is now. Will continue another day

aristath avatar May 09 '17 21:05 aristath

Moving to the 3.1 milestone. The current implementation (a combo of PHP & JS) works. It's not perfect, but it works fine and there are no issues with it. This refactoring item can be taken care of after the release of 3.0

aristath avatar May 18 '17 16:05 aristath