bert
bert copied to clipboard
Fix 59 bert jquery codependence
Fixes #59
This is a fairly major change.
- Swapped out all jquery calls for native document calls.
- Changed the animation to depend on
animate.css
, which is included in the project. (Might want to keep it out? let the caller includeanimate.css
, likefontawesome
?) - Also, because of the major changes. I did a few refactoring items...
- use requestAnimationFrame instead of setting a timeout
- Completely refactored
setBertOnSession
for what was a good reason during development, but as my design finished the good reason disappeared.
Functionality/API should be exactly the same.
Looking at this now @brucejo75. Looks like the layout is broken. The alert is flush against the browser edge but should have a ~10-20px gap like the current version.
@cleverbeagle, OK found my mistake and repaired...
@cleverbeagle, got rid of merge conflict... good to go.
@cleverbeagle, any chance this could get merged?
@brucejo75 looking now but having some trouble running the code. Do you know what Meteor, Node, and NPM versions you tested against? The error I'm getting is fairly ambiguous but seems to be an issue with one of those versions.
Hi @cleverbeagle,
I am running this against meteor
v1.10.2. I think the newest keyword I used was import
, maybe that is an issue on really old versions of Meteor?
Maybe this is a breaking change for really old versions?
Can you forward me some of the errors and your meteor version? I can check it out... maybe I am using some other constructs that need to be removed for older versions of meteor
. (class
keyword?)
@cleverbeagle, any status? Thanks!
@cleverbeagle, @themeteorchef, any chance we could get this merged?
Should I get rid of Bert or wait for this merge :thinking: