bert icon indicating copy to clipboard operation
bert copied to clipboard

Fix 59 bert jquery codependence

Open brucejo75 opened this issue 4 years ago • 9 comments

Fixes #59

This is a fairly major change.

  1. Swapped out all jquery calls for native document calls.
  2. Changed the animation to depend on animate.css, which is included in the project. (Might want to keep it out? let the caller include animate.css, like fontawesome?)
  3. Also, because of the major changes. I did a few refactoring items...
  • use requestAnimationFrame instead of setting a timeout
  • Completely refactored setBertOnSession for what was a good reason during development, but as my design finished the good reason disappeared.

Functionality/API should be exactly the same.

brucejo75 avatar May 31 '20 00:05 brucejo75

Looking at this now @brucejo75. Looks like the layout is broken. The alert is flush against the browser edge but should have a ~10-20px gap like the current version.

cleverbeagle avatar Jun 17 '20 23:06 cleverbeagle

@cleverbeagle, OK found my mistake and repaired...

brucejo75 avatar Jun 18 '20 00:06 brucejo75

@cleverbeagle, got rid of merge conflict... good to go.

brucejo75 avatar Jul 10 '20 22:07 brucejo75

@cleverbeagle, any chance this could get merged?

brucejo75 avatar Dec 21 '20 23:12 brucejo75

@brucejo75 looking now but having some trouble running the code. Do you know what Meteor, Node, and NPM versions you tested against? The error I'm getting is fairly ambiguous but seems to be an issue with one of those versions.

cleverbeagle avatar Jan 04 '21 15:01 cleverbeagle

Hi @cleverbeagle,

I am running this against meteor v1.10.2. I think the newest keyword I used was import, maybe that is an issue on really old versions of Meteor?

Maybe this is a breaking change for really old versions?

Can you forward me some of the errors and your meteor version? I can check it out... maybe I am using some other constructs that need to be removed for older versions of meteor. (class keyword?)

brucejo75 avatar Mar 28 '21 19:03 brucejo75

@cleverbeagle, any status? Thanks!

brucejo75 avatar May 07 '21 14:05 brucejo75

@cleverbeagle, @themeteorchef, any chance we could get this merged?

brucejo75 avatar Aug 30 '21 20:08 brucejo75

Should I get rid of Bert or wait for this merge :thinking:

muikku avatar Jun 24 '22 07:06 muikku