flowbite icon indicating copy to clipboard operation
flowbite copied to clipboard

Figma File - Layer colors in Figma component instances fail to maintain persist override

Open jehtee opened this issue 1 year ago • 2 comments

Bug Description

Layer colors in Figma component instances fail to maintain persist override.

Reproduction

If we take the button component for example, and drag an instance onto the canvas image

And then try to override left icon image

Notice how it looses the white color defined in the Button component and displays the color of the new icon. This makes the component partially useless as a DRY component since this color would have to be updated in each instance that uses a different icon.

The reason for this is that Figma uses the layer name to manage inheritance. And the icon layers in Flowbite are all unique. So They cannot inherit any values, like color.

Expected Behavior

Property overrides to component instances should be inherited.

Solution

One way to fix this is to normalize the names of the icons layers. So in the case of the button they should be something like "Left Button" and "Right Button" rather than the unique name of the icon itself.

Such a fix (or any other) should be implemented by FlowBite for obvious reasons.

Environment

  • MacOS
  • MBP M1

jehtee avatar May 17 '23 22:05 jehtee

Is this still an issue @robert1508?

zoltanszogyenyi avatar Jun 27 '24 11:06 zoltanszogyenyi

We will come next month with an update and we will try to solve these problems.

robert1508 avatar Jun 27 '24 12:06 robert1508