flowbite-vue icon indicating copy to clipboard operation
flowbite-vue copied to clipboard

fix: FwbCard: Removed hover on non-links cards

Open andreyjamer opened this issue 1 year ago β€’ 2 comments

Current implementation of card has hover effect for the case when the card is not a link. And on the other hand it does not have hover effect for the case when the card contains image and has a link. This PR fixes this behavior

Summary by CodeRabbit

  • New Features

    • Introduced an optional href property to enhance the card component's functionality, allowing for hyperlinking capabilities.
    • Improved hover effects on the card component based on the presence of the href property, enhancing user interaction.
  • Refactor

    • Updated the logic for generating class strings in the card component to accommodate the new href property and improve responsiveness.

andreyjamer avatar Sep 06 '24 06:09 andreyjamer

Walkthrough

The changes introduce an optional href property to the UseCardsClassesProps type in the useCardClasses.ts file. This modification allows the useCardsClasses function to dynamically generate class strings based on the variant and the presence of the href, enhancing the component's styling capabilities.

Changes

Files Change Summary
src/components/FwbCard/composables/useCardClasses.ts Added an optional href property to UseCardsClassesProps and refactored useCardsClasses to conditionally build class strings based on variant and href.

Poem

In a meadow bright, with a hop and a cheer,
A card now links, oh so near!
With classes that dance, and styles that play,
A new href shines, brightening the day.
So let’s leap and bound, with joy we’ll say,
"Hooray for the changes, hip-hip-hooray!" πŸ‡βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 06 '24 06:09 coderabbitai[bot]

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
Latest commit 43db9b064ae4b6370b1bb0bb37172f4043c58029
Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/66daadf8492a6300084bf64f
Deploy Preview https://deploy-preview-321--sensational-seahorse-8635f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 06 '24 06:09 netlify[bot]