flowbite-vue
flowbite-vue copied to clipboard
fix: Fixed sizes for toggle components
Toggle component has problems with sizes. Especially the sm size:
Here is a fix with proper Tailwind classes
Deploy Preview for sensational-seahorse-8635f8 ready!
| Name | Link |
|---|---|
| Latest commit | 1851aee4aceabc163097e25f828ebc4a8ff29105 |
| Latest deploy log | https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/667d7191bec2a70008edfff1 |
| Deploy Preview | https://deploy-preview-295--sensational-seahorse-8635f8.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @andreyjamer 👋
Can you please fix conflict... it clashes with your other PR ;)
Walkthrough
The recent changes enhance the toggle component's adaptability for different layouts, particularly for right-to-left (RTL) languages. Key improvements include the introduction of RTL support in CSS class definitions and adjustments to align properties with modern practices. These modifications ensure the toggle is more accessible and user-friendly across various language contexts, improving overall responsiveness and usability.
Changes
| Files | Change Summary |
|---|---|
src/components/FwbToggle/composables/useToggleClasses.ts |
Added rtl: prefix to CSS classes for RTL support; replaced left with start in size variants to enhance responsiveness. |
Poem
🐰 In a world where toggles sway,
RTL dances in bright array.
Classes shift, and all is right,
Usability takes flight,
With each flick, we cheer and play,
A joyful leap in CSS ballet! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Ok, I'm closing this one... as this changes are already merged with this PR