flowbite-svelte icon indicating copy to clipboard operation
flowbite-svelte copied to clipboard

fix: full width mega menu displacement and content overflow

Open ttytm opened this issue 1 year ago β€’ 5 comments

πŸ“‘ Description

Fixes a displacement and overflow of the full-width mega-menu that happens due to the default space-x of the parent navigation element.

Current Updated
Screenshot_20240710_111941 Screenshot_20240710_111909

Current ref.: https://flowbite-svelte.com/docs/components/mega-menu#Full_width_with_image

Status

  • [x] Completed

βœ… Checks

  • [x] My pull request adheres to the code style of this project
  • [x] I have updated the documentation as required
  • [x] I have checked the page with https://validator.unl.edu/
  • [x] All the tests have passed
  • [x] My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

Summary by CodeRabbit

  • Style
    • Updated the MegaMenu styling to improve layout when in full mode.

ttytm avatar Jul 10 '24 09:07 ttytm

@ttytm is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 10 '24 09:07 vercel[bot]

Walkthrough

The change in MegaMenu.svelte enhances styling by conditionally adding the !ml-0 class when the full property is true. This tweak adjusts the margin settings of the wrapper element, ensuring it aligns correctly when displayed in full width mode. No public or exported entities were altered.

Changes

File Path Summary
src/lib/mega-menu/MegaMenu.svelte Added !ml-0 class to wrapperClass when full is true to modify styling.

Poem

Amidst the code, a change so slight,
A class added, making margins right,
!ml-0 for the full display,
Enhancing styles in a subtle way.
🎨🌟 In MegaMenu's dance, a tiny tweak,
Making the layout sleek and chic! ✨🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 10 '24 09:07 coderabbitai[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 24, 2024 4:15pm

vercel[bot] avatar Sep 24 '24 16:09 vercel[bot]

I don't see the problem.

image

shinokada avatar Sep 24 '24 16:09 shinokada

I don't see the problem.

image

370369890-8d6807eb-4d45-4e4b-b9c3-5436ff613fa4

Thanks for the review @shinokada

It's in the image you shared. I'm adding annotations to the image to make it obvious. The "want-state" is visible in the Updated cell in the PR description.

The PR was opened and tested on linux. Now I retested on macOS in a Chromium based browser and also Firefox and can confirm the issue exists.

ttytm avatar Sep 24 '24 17:09 ttytm

Thank you for your PR.

shinokada avatar Oct 27 '24 15:10 shinokada