Fix: Disabled Button

[tommygiesbrecht]

Closes #

📑 Description

The disabled attribute is not applied to the button.

Status

• [x] Not Completed
• [x] Completed

✅ Checks

• [x] My pull request adheres to the code style of this project
• [x] My code requires changes to the documentation
• [x] I have updated the documentation as required
• [x] I have checked the page with https://validator.unl.edu/
• [x] All the tests have passed
• [x] My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

[vercel[bot]]

Someone is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

This update enhances the Button.svelte component by incorporating the spread operator to pass all additional properties to the <svelte:element> within a conditional statement. This change simplifies prop management and increases the component's flexibility without altering any public or exported entities.

Changes

File	Change Summary
.../Button.svelte	Added spread operator to pass all remaining props conditionally

🐇✨ A tiny tweak in the code, a giant leap for flexibility, Now Button dances with props, so sprightly and nimbly. Through fields of code it hops, with ease and grace, Spreading joy with each prop, in its rightful place. 🎉🐰💻

---

Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c2b90ac2b0e30635e866e0a330dfa2275d9f21d and 8addf0fdaac13e9d534d93093a0978cd2d5abda7.

Files selected for processing (1)

• src/lib/buttons/Button.svelte (1 hunks)

Files skipped from review due to trivial changes (1)

• src/lib/buttons/Button.svelte

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-svelte	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2024 6:47pm

[shinokada]

I intentionally removed it. Please see https://github.com/themesberg/flowbite-svelte/issues/1328.

[tommygiesbrecht]

@shinokada The button has no attribute disabled. So my test cases failed because I can't check if the button is disabled. Maybe we can add disabled={true} instead of {...$$restProps}

[jbraswell]

Would love to see this fixed. As it stands, it seems impossible to disable a form's submit button without hacking around this bug. Has anyone found a clean workaround?

[shinokada]

@jbraswell It is already fixed. If you have any problems, please create a new issue. Thanks.