flowbite-react icon indicating copy to clipboard operation
flowbite-react copied to clipboard

fix: Customize Theme was showing wrong example for color

Open dhavalveera opened this issue 10 months ago • 5 comments

This PR is fixing a documentation error specifically for the Button component. As we don't have any color option called as Primary

image Customize Theme - Option 3

the below is the fix of the documentation with the correct color option in the custom theme option.

image

Summary by CodeRabbit

  • Documentation
    • Updated the custom theme documentation to reflect the renaming of the color key from "primary" to "failure" for button styling, enhancing semantic clarity.

dhavalveera avatar Apr 17 '24 05:04 dhavalveera

⚠️ No Changeset found

Latest commit: b116788be57f7bc5a89631c748db437df899d850

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 17 '24 05:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 5:12am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 5:12am

vercel[bot] avatar Apr 17 '24 05:04 vercel[bot]

Walkthrough

The update involves a semantic change in the custom theme for buttons, where the color key "primary" is renamed to "failure." This change affects the button color styling specifically in the MyPage component.

Changes

File Path Change Summary
apps/web/content/docs/.../theme.mdx Renamed color key from "primary" to "failure" in button theme

Possibly related issues

  • themesberg/flowbite-react#1219: This issue discusses respecting theme settings in components, similar to how the PR respects theme changes in button styling.
  • themesberg/flowbite-react#1301: The focus on theming consistency in this issue aligns with the PR's theme key renaming for better semantic clarity.

🐇✨ In the land of code where themes intertwine, A rabbit hopped through, making changes divine. From 'primary' to 'failure', a key did shift, In buttons it changed, giving themes a lift. Hopping away, the rabbit felt slick, Leaving behind code, wonderfully quick. 🌟🐰


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8ae8b16de4f9b28b088f9512d90e00e24d26c4b4 and b116788be57f7bc5a89631c748db437df899d850.
Files selected for processing (1)
  • apps/web/content/docs/customize/theme.mdx (2 hunks)
Additional comments not posted (3)
apps/web/content/docs/customize/theme.mdx (3)

42-42: The update to use the color key "failure" is clear and aligns well with the intended semantic meaning.


50-50: Correct usage of the "failure" color key in the Button component, consistent with the custom theme settings.


66-72: The definition and application of the custom theme with the "failure" color key are correctly implemented.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 17 '24 05:04 coderabbitai[bot]

I also have this issue... need to manage all colors manually... 🥲 @SutuSebastian

vitalijalbu avatar Jun 07 '24 12:06 vitalijalbu

There is work planned to introduce the primary color in tailwind.config.(js/ts/cjs/mjs) file, so I'm just gonna leave this here for now.

SutuSebastian avatar Jun 19 '24 12:06 SutuSebastian